Fix cluster artifacts and negative light #82546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viksl
changed the title
akien-mga
changed the title
|
Could you amend the commit message to fix the typo and make it shorter, like the PR title? A commit message should have a short, imperative sentence as title, and additional context can be given in the body of the message. |
|
Oki, I think I did it wrong so I'll try to squash it into one commit today. EDIT: Is it ok now? |
viksl
force-pushed
the
volumetric-fog-spot-light-artifacts
branch
from
2284c3a
to
8a2d345
Compare
clayjohn
approved these changes
Oct 5, 2023
clayjohn
added
the
cherrypick:4.1
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78500
Instructions:
Definitely should be merged on top of this PR: #80992
Details:
Just added the same shader adjustment for the cone angle as in this PR: #71832 it might have been just forgotten?
EDIT:
There's one more place which also uses the cone angle, but this time in gles3 shader, which doesn't use the
highpfor the cone angle in case it matters (?), the original author did not rework that one, it might not be an issue but I'm keeping this note here in case in future there's a similar clustered artifact issue with spotlight in gles3 in some other areas, it might not be need to make a change there at all but let's try not to foget it.