Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCons: Change check_c_headers from tuple array to dictionary #82638

Merged
merged 1 commit into from
Oct 3, 2023
Merged

SCons: Change check_c_headers from tuple array to dictionary #82638

merged 1 commit into from
Oct 3, 2023

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Oct 1, 2023

Minor alteration to one of the SCons checks. It's largely identical to the old method, but a dictionary is more scalable & the formatting becomes in-line with the rest of the SCons files

@Repiteo Repiteo requested review from a team as code owners October 1, 2023 19:17
@Calinou Calinou added this to the 4.x milestone Oct 1, 2023
Riteo
Riteo approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@Riteo Riteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know this part of the build system that well but this looks fine, nice and simple.

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Oct 2, 2023
akien-mga
akien-mga approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not :)

@akien-mga akien-mga merged commit 090a5b0 into godotengine:master Oct 3, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Repiteo Repiteo deleted the check_c_headers-to-dictionary branch October 3, 2023 15:45
@akien-mga akien-mga changed the title check_c_headers from tuple array to dictionary SCons: Change check_c_headers from tuple array to dictionary Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@Riteo Riteo Riteo approved these changes

Assignees
No one assigned
Labels
enhancement topic:buildsystem
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Repiteo @akien-mga @Riteo @Calinou