OpenXR - add access to hand joint validity flags #82715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Oct 3, 2023
BastiaanOlij
force-pushed
the
openxr_hand_joint_validity_flags
branch
3 times, most recently
from
ea6b707
to
9c5ccfc
Compare
m4gr3d
approved these changes
Oct 3, 2023
|
Needs rebase. |
|
@akien-mga I suggest we merge #82722 first and then we rebase this, there is an overlap in changes I want to prevent doing twice and it's easier to adjust this PR than the other. |
|
Needs rebase. |
BastiaanOlij
force-pushed
the
openxr_hand_joint_validity_flags
branch
from
9c5ccfc
to
ed154ed
Compare
BastiaanOlij
force-pushed
the
openxr_hand_joint_validity_flags
branch
from
ed154ed
to
50693a5
Compare
|
@akien-mga ok rebased, and tested on my Quest Pro, seems to be working great now! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds access to the validity flags in OpenXR hand tracking data.
This is a follow up to #78032, we missed exposing these flags.