Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix garbled text in editor toasters #82913

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

timothyqiu
Copy link
Member

EditorToaster didn't take potential UTF-8 messages into account. A localized message might look like this:

image

@timothyqiu timothyqiu added bug topic:editor cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Oct 6, 2023
@timothyqiu timothyqiu added this to the 4.2 milestone Oct 6, 2023
@timothyqiu timothyqiu marked this pull request as ready for review October 6, 2023 13:44
@akien-mga akien-mga merged commit 62ca46c into godotengine:master Oct 6, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the toasters branch October 6, 2023 14:59
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants