Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move animation slice processing to _post_fix_animations #83036

Conversation

jsjtxietian
Copy link
Contributor

@jsjtxietian jsjtxietian commented Oct 9, 2023

Fixes #81955.
Fixes #82753

The issue owner successfully test it and it works. I would appreciate any feedback or alternative suggestions.

@jsjtxietian jsjtxietian requested a review from a team as a code owner October 9, 2023 09:52
@jsjtxietian jsjtxietian force-pushed the move-animation-slice-processing-to-_post_fix_animations branch from 233c569 to 3a85e4b Compare October 9, 2023 10:59
@fire fire requested a review from a team October 9, 2023 19:19
@jsjtxietian jsjtxietian changed the title [WIP] Move animation slice processing to _post_fix_animations Move animation slice processing to _post_fix_animations Oct 10, 2023
@jsjtxietian jsjtxietian marked this pull request as draft October 10, 2023 09:58
@jsjtxietian jsjtxietian marked this pull request as ready for review October 11, 2023 02:08
@Chaosus Chaosus added this to the 4.2 milestone Oct 11, 2023
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, LGTM! 👍

@SaracenOne
Copy link
Member

Supercedes #83036

@YuriSizov YuriSizov merged commit 802813d into godotengine:master Nov 3, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@jsjtxietian jsjtxietian deleted the move-animation-slice-processing-to-_post_fix_animations branch November 3, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants