Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenGL directional shadow last split fading #83252

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

mrjustaguy
Copy link
Contributor

Fixes #82505

I have no ideas what pssm fade was ment to do, however based on the shader code my guess is that it was an attempt to apply the fading controlled by fade start that got scrapped halfway through the implementation and replaced with a proper implementation, given that I cannot see anything of the sort in the Vulkan Renderer to indicate some other specific feature.

@mrjustaguy mrjustaguy requested a review from a team as a code owner October 13, 2023 09:10
@mrjustaguy mrjustaguy changed the title Remove PSSM Fade Fix OpenGL Directional Shadow Last Split Fading Oct 13, 2023
@akien-mga akien-mga added this to the 4.2 milestone Oct 13, 2023
drivers/gles3/shaders/scene.glsl Outdated Show resolved Hide resolved
drivers/gles3/shaders/scene.glsl Outdated Show resolved Hide resolved
Copy link
Contributor

@jsjtxietian jsjtxietian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please squash these commits ? Godot contributing workflow says: “Most of the time, we will prefer a single commit in a given PR (unless there's a good reason to keep the changes separate).”

https://docs.godotengine.org/en/stable/contributing/workflow/pr_review_guidelines.html#get-feedback-from-the-right-people-teams

@mrjustaguy
Copy link
Contributor Author

Squashed

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, let's nuke it. This was an accidental copy-paste from the GLES2 code in Godot 3.x

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

@akien-mga akien-mga merged commit a19f056 into godotengine:master Oct 13, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@mrjustaguy mrjustaguy deleted the opengl-fade-fix branch October 14, 2023 08:09
@akien-mga akien-mga changed the title Fix OpenGL Directional Shadow Last Split Fading Fix OpenGL directional shadow last split fading Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenGL: DirectionalLight3D applies Fade Start incorrectly when using PSSM 2 Splits or 4 Splits mode
6 participants