Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make error suggestion less ambiguous #83327

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Make error suggestion less ambiguous #83327

merged 1 commit into from
Oct 16, 2023

Conversation

AThousandShips
Copy link
Member

As discussed on chat, not sounding passive-aggressive in English is a challenge.

@AThousandShips AThousandShips added this to the 4.2 milestone Oct 14, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner October 14, 2023 13:00
@AThousandShips AThousandShips added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 14, 2023
@AThousandShips
Copy link
Member Author

Looked and this was the only instance like this, there are a few others but they say things like "read the documentation for details about"

@akien-mga akien-mga merged commit e551d5f into godotengine:master Oct 16, 2023
15 checks passed
@AThousandShips AThousandShips deleted the doc_suggestion branch October 16, 2023 08:45
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@AThousandShips @akien-mga @YuriSizov