Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grammar typo in GDScript error message #83455

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix grammar typo in GDScript error message #83455

merged 1 commit into from
Oct 17, 2023

Conversation

Lunarisnia
Copy link
Contributor

Fixes #83453

@Lunarisnia Lunarisnia requested a review from a team as a code owner October 16, 2023 18:30
@akien-mga
Copy link
Member

akien-mga commented Oct 16, 2023 •
edited
Loading

The point of that issue was to remove "a", not change it to "an".

This change here would be wronger for any type that's not "int".

@AThousandShips
Copy link
Member

The issue is indeed that the type can be both "a" and "an" so no article

@akien-mga akien-mga added this to the 4.2 milestone Oct 16, 2023
@dalexeev

This comment was marked as outdated.

Sign in to view
@akien-mga akien-mga merged commit 109cb8e into godotengine:master Oct 17, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexeev dalexeev dalexeev approved these changes

Assignees
No one assigned
Labels
bug topic:gdscript
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Grammar typo in GDScript error message
4 participants
@Lunarisnia @akien-mga @AThousandShips @dalexeev