Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix close button in FindReplaceBar #83459

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix close button in FindReplaceBar #83459

merged 1 commit into from
Oct 17, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Oct 16, 2023

Fixes #83456

@KoBeWi KoBeWi added this to the 4.2 milestone Oct 16, 2023
@KoBeWi KoBeWi requested a review from a team as a code owner October 16, 2023 19:52
@k0T0z
Copy link
Contributor

k0T0z commented Oct 16, 2023

@KoBeWi Sorry but I looked into this issue and I am very curious to know how this solves it? I thought that p_force_focus is an optional parameter!

@KoBeWi
Copy link
Member Author

KoBeWi commented Oct 16, 2023

callable_mp() doesn't support optional parameters. It's some method pointer limitation, AFAIK it can't be solved.

@k0T0z
Copy link
Contributor

k0T0z commented Oct 16, 2023

@KoBeWi hmm, I guess now I am sure that godot has its own GUI framework

@AThousandShips
Copy link
Member

Default arguments aren't supported for pointers like this AFAIK, they are a compiler side thing, don't even know if C++ introspection can even detect them at all

@Calinou
Copy link
Member

Calinou commented Oct 16, 2023

Note: No cherry-picking is needed as #83456 only affects master.

@akien-mga akien-mga merged commit 837f091 into godotengine:master Oct 17, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the bug=false branch October 17, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Cannot close search bar in script editor
5 participants
@KoBeWi @k0T0z @AThousandShips @Calinou @akien-mga