Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add path option to ScriptLanguageExtension::_validate #83588

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Add path option to ScriptLanguageExtension::_validate #83588

merged 1 commit into from
Oct 24, 2023

Conversation

voidedWarranties
Copy link
Contributor

Currently, _validate works for warnings but not errors. This should fix it.

@voidedWarranties voidedWarranties requested a review from a team as a code owner October 18, 2023 23:39
@AThousandShips AThousandShips added this to the 4.2 milestone Oct 19, 2023
@dsnopek dsnopek requested a review from a team October 19, 2023 12:27
dsnopek
dsnopek reviewed Oct 22, 2023
View reviewed changes
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It definitely looks like you've found a bug - great catch :-)

I have a couple of notes in my code comments about the solution. However, I'm not an expert in the script APIs, so I'm making some guesses just from reading the related code.

core/object/script_language_extension.h Outdated Show resolved Hide resolved
core/object/script_language_extension.h Outdated Show resolved Hide resolved
dsnopek
dsnopek approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me :-)

@akien-mga akien-mga merged commit 792afd2 into godotengine:master Oct 24, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@voidedWarranties voidedWarranties deleted the fix_sle_validate branch October 24, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
bug topic:core topic:gdextension
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@voidedWarranties @akien-mga @dsnopek @AThousandShips