Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify NOTIFICATION_SCROLL_BEGIN/END behavior #83636

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Clarify NOTIFICATION_SCROLL_BEGIN/END behavior #83636

merged 1 commit into from
Oct 27, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Oct 19, 2023 •
edited
Loading

Documents that these notifications are only sent for touch events. Expands the details from #81517, the notification is propagated at the same time as the signals are emitted.

@AThousandShips AThousandShips added enhancement documentation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Oct 19, 2023
@AThousandShips AThousandShips added this to the 4.2 milestone Oct 19, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner October 19, 2023 20:30
@AThousandShips
Clarify NOTIFICATION_SCROLL_BEGIN/END behavior
44f62a4 
Documents that these notifications are only sent for touch events.
@AThousandShips
Copy link
Member Author

Could alternatively point to the signals and say something like:
[b]Note:[/b] This notification is sent under the same conditions as [signal ScrollContainer.scroll_started/ended].

But think it's good to have it here as well to not risk people missing it

@AThousandShips AThousandShips added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Oct 26, 2023
@AThousandShips AThousandShips modified the milestones: 4.2, 4.3 Oct 26, 2023
SaracenOne
SaracenOne approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AThousandShips AThousandShips modified the milestones: 4.3, 4.2 Oct 27, 2023
@AThousandShips AThousandShips removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Oct 27, 2023
@akien-mga akien-mga merged commit bcf8a21 into godotengine:master Oct 27, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the scroll_doc branch October 27, 2023 19:48
@AThousandShips
Copy link
Member Author

Thank you!

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaracenOne SaracenOne SaracenOne approved these changes

@Calinou Calinou Awaiting requested review from Calinou

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Scroll begin and Scroll end notifications are not sent
4 participants
@AThousandShips @akien-mga @YuriSizov @SaracenOne