Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "version" project setting as macOS/iOS "short_version" fallback. #83686

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Oct 20, 2023

Fixes #83684

Both short_version and version are using the same format ([Major].[Minor].[Patch], but full version can include additional integers), so the same fallback can be used.

@bruvzg
Copy link
Member Author

bruvzg commented Oct 20, 2023

We probably should also add build_nr project settings (which is autoincremented on export) and append it to the full macOS/iOS version. I'll check what's the expected version formats on other platforms later (at least Windows seems to be 4 ints, so it can auto use build_nr too, Android seems to use versionCode for the same purpose).

@akien-mga akien-mga merged commit 6543495 into godotengine:master Oct 20, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the short_ver_fb branch October 20, 2023 20:21
@lostminds
Copy link

We probably should also add build_nr project settings (which is autoincremented on export) and append it to the full macOS/iOS version. I'll check what's the expected version formats on other platforms later (at least Windows seems to be 4 ints, so it can auto use build_nr too, Android seems to use versionCode for the same purpose).

I think this sounds like a very good idea, and have "Short version" default to the project version setting and "Version" default to the project version setting+this new build_nr. You might have to investigate if appstore submissions support four-component versions like windows though. It didn't in the past, and invalid versions will block submission. But this might have changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants