Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vertical scrolling to bézier track editor. #83776

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

SaracenOne
Copy link
Member

@SaracenOne SaracenOne commented Oct 22, 2023

While the bézier editor likely needs a much broader UX pass, this at least adds means to scroll the track list, the absence of which makes the bézier editor basically unusable with large numbers of tracks.

godot windows editor dev x86_64_xpMQOQe8x8

Closes #74577

Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design approval. The feature is a good idea. Haven’t done a technical review.

@akien-mga akien-mga merged commit 943b741 into godotengine:master Oct 23, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@fire fire deleted the bezier_track_scroll branch October 23, 2023 16:50
@GNSS-Stylist
Copy link
Contributor

@SaracenOne Sorry, but this doesn't seem to work on my setup. :( Scroll wheel of the mouse or two-finger scroll-gesture on the touchpad don't do anything unless zoom modifiers (CTRL / ALT) are pressed.

First I though this was broken again later (started working with post-RC1-version), but this new issue seemed to appear right after this commit (switched/checked out versions right before this and this).

Could this be related to OS/HW-setup? My system (From Godot's Help->Copy System Info): Godot v4.2.rc (1ba920f) - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 (NVIDIA; 31.0.15.4601) - Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz (12 Threads)

This is a Lenovo laptop with touchpad and an external mouse (Logitech M705). Everything else seems to work with this setup, including scrolling in other parts of the Godot's UI.

Sorry for taking so long before testing this (as the opener of the related issue), but I only just started to work again with the bézier-editor.

Don't know how this should be handled so writing this comment here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animation bezier curve editor's track list can't be scrolled
4 participants