Add dotted grid to GraphEdit #83785
Merged
Add dotted grid to GraphEdit #83785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geometror
force-pushed
the
graphedit-dotted-grid
branch
from
02f60fa
to
9226076
Compare
fire
approved these changes
Oct 22, 2023
|
Looks good to me, though i think it should be possible to toggle it off in visual shaders |
|
@QbieShay This PR only adds the new patterns to GraphEdit, the VisualShader editor remains completely unchanged. I plan to apply it to the editor in a separate PR together with some other UI/UX improvements (there will be an editor setting for changing the grid pattern). |
|
Yepp sorry for the misunderstanding! |
|
This dotted grid may be a good addition to the 2D editor in the future 🙂 |
Geometror
force-pushed
the
graphedit-dotted-grid
branch
from
9226076
to
4770f25
Compare
AThousandShips
approved these changes
Nov 10, 2023
Geometror
force-pushed
the
graphedit-dotted-grid
branch
from
4770f25
to
1a8e676
Compare
|
Thanks! Let's make use of this in the editor as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a
grid_patternproperty forGraphEdit.The new dotted pattern adapts to the zoom level (fading) and should be a bit more pleasant to the eye.
This PR only contains the additon to
GraphEdit, but to demonstrate how it could look I tested it on the VisualShader editor: