fix OpenBSD build error: implicit instantiation of undefined template… #83804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
reviewed
Oct 23, 2023
| @@ -129,6 +129,9 @@ MAKE_TYPE_INFO_WITH_META(int8_t, Variant::INT, GodotTypeInfo::METADATA_INT_IS_IN | |||
| MAKE_TYPE_INFO_WITH_META(uint16_t, Variant::INT, GodotTypeInfo::METADATA_INT_IS_UINT16) | |||
| MAKE_TYPE_INFO_WITH_META(int16_t, Variant::INT, GodotTypeInfo::METADATA_INT_IS_INT16) | |||
| MAKE_TYPE_INFO_WITH_META(uint32_t, Variant::INT, GodotTypeInfo::METADATA_INT_IS_UINT32) | |||
| #ifdef __OpenBSD__ | |||
| MAKE_TYPE_INFO_WITH_META(unsigned long, Variant::INT, GodotTypeInfo::METADATA_INT_IS_UINT32) | |||
There was a problem hiding this comment.
This might result in duplicate template errors (should be checked on both 32-bit and 64-bit builds).
Usually, this type of errors can be fixed by simply adding uint64_t cast to the place where ambiguous int is assigned to the Variant variable.
|
it looks like we have found where to use |
|
Would be good to upstream this patch. |
|
PR to upstream here: #84017 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… 'GetTypeInfo'
I'm not sure why OpenBSD build needs
GetTypeInfo<unsigned long>but apparently this isn't an issue on other platforms. This diff supplies this, with basically the same content as forGetTypeInfo<ObjectID>which appears to consist of a UINT64.Would like feedback on if I'm missing anything here. I'm able to complete the build with this in place.