Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation related for particle subemitters, collision and attractors #83916

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Improve documentation related for particle subemitters, collision and attractors #83916

merged 1 commit into from
Oct 27, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 25, 2023

This also describes how to set up particle flipbook animation in GPUParticles2D's texture property.

@Calinou Calinou requested a review from a team as a code owner October 25, 2023 04:16
@Calinou Calinou added this to the 4.2 milestone Oct 25, 2023
AThousandShips
AThousandShips reviewed Oct 25, 2023
View reviewed changes
doc/classes/ParticleProcessMaterial.xml Outdated Show resolved Hide resolved
doc/classes/GPUParticles2D.xml Outdated Show resolved Hide resolved
@Calinou
Improve documentation related for particle subemitters, collision and…
22e42c1 
… attractors

This also describes how to set up particle flipbook animation in
GPUParticles2D's texture property.
@Calinou Calinou force-pushed the doc-particles-collision-subemitters branch from 41ec92f to 22e42c1 Compare October 25, 2023 18:44
QbieShay
QbieShay approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@QbieShay QbieShay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you

I was a bit concerned by the mention of flipbook because I wasn't sure how standard it is, but it does seem pretty standard.

@akien-mga akien-mga merged commit 73130a2 into godotengine:master Oct 27, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcdk mrcdk mrcdk left review comments

@AThousandShips AThousandShips AThousandShips left review comments

@QbieShay QbieShay QbieShay approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

GPU Particles 3D has no documentation about using Visibility AABB for collisions
5 participants
@Calinou @akien-mga @mrcdk @QbieShay @AThousandShips