Fix UV editor not using texture transform #84076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:editor
topic:2d
cherrypick:4.1
KoBeWi
approved these changes
Nov 5, 2023
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.1. |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you set Polygon2D's texture transform (offset, scale or rotation), texture would still draw with default transform in UV editor.
Properties:
Bug in UV editor:
Fixed:
MRP: TextureTransformMRP.zip
I didn't find any existing issues about this. As a side effect of this fix, if you rotate the texture 90-270 degrees (and no offset), the texture isn't going to be in the initial view (it's rotated around the top-left corner). Well, it's better than texture appearing in the wrong place altogether, but might be a bit confusing. See #83731 for a fix for that problem (altough it should be updated for transformed textures after this pr).