-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix turbulence post rework #84103
Fix turbulence post rework #84103
Conversation
8de807d
to
fb10398
Compare
fb10398
to
a7b5a9d
Compare
After having a conversation with @RPicster , we decided to move the scale changes out of this PR. |
a7b5a9d
to
55e711b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really have enough knowledge about the turbulence code to give a substantive approval. The code changes look fine to me and I don't think they will have unintended consequences in other parts of the code.
What I can't say is whether the behavioral change is desirable or aligns better with how things worked in 4.1.x.
Would be helpful to have @RPicster's approval as well
More detail on what was happening: The turbulence change of direction was applied only to the combined value of animated velocities and velocity, but velocity was never updated. This was causing the interpolation code to flicker the particle back and forth. Additionally, this was "holding back" the turbulence from properly forming patterns because the particles were constantly pulled in different directions. |
The commit message should be amended if it no longer includes scale changes. |
55e711b
to
3b9cd04
Compare
Thanks! |
Turbulence wasn't correctly altering the velocity vector which caused flickering with interpolation and disruption of the noise pattern.
Additionally, scale for 2D is now more usable in the inspector.Soft compat breakage with existing 2D particles that use turbulence.Video of the visual change:2023-10-28.11-40-12.mp4
2023-10-28.12-24-12.mp4