Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cubemap downsampler logic #84223

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fix cubemap downsampler logic #84223

merged 1 commit into from
Oct 31, 2023

Conversation

BastiaanOlij
Copy link
Contributor

Small fixes that resolves #83227 resulting in radiance cubemap not being updated correctly.

@BastiaanOlij BastiaanOlij added this to the 4.2 milestone Oct 30, 2023
@BastiaanOlij BastiaanOlij self-assigned this Oct 30, 2023
@BastiaanOlij BastiaanOlij requested a review from a team as a code owner October 30, 2023 23:48
@BastiaanOlij
Copy link
Contributor Author

This was a small mistake introduced through #80311

Calinou
Calinou approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

Forward+ Mobile Compatibility
Screenshot_20231031_083458 Screenshot_20231031_083445 Screenshot_20231031_083510

@akien-mga akien-mga added the bug label Oct 31, 2023
clayjohn
clayjohn approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@akien-mga akien-mga merged commit 3196135 into godotengine:master Oct 31, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@BastiaanOlij BastiaanOlij deleted the fix_mobile_radiance_sky branch October 31, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees

@BastiaanOlij BastiaanOlij

Labels
bug regression topic:rendering topic:3d
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Vulkan Mobile: Radiance map rendering is broken after 4.2.dev2
4 participants
@BastiaanOlij @akien-mga @Calinou @clayjohn