Add function to get navigation map iteration id from NavigationServer #84275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smix8
force-pushed
the
navmap_iteration_id
branch
2 times, most recently
from
7bd9f1f
to
b5b3d35
Compare
smix8
added
the
cherrypick:4.2
smix8
force-pushed
the
navmap_iteration_id
branch
2 times, most recently
from
52ff43d
to
3cf3956
Compare
Scony
reviewed
Feb 20, 2024
Scony
approved these changes
Feb 21, 2024
Adds function to get navigation map iteration id from NavigationServer.
smix8
force-pushed
the
navmap_iteration_id
branch
from
3cf3956
to
313c1d1
Compare
|
Removed the old |
akien-mga
approved these changes
Feb 22, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds NavigationServer
map_get_iteration_id()function to get current navigation map iteration id.This is useful to give users an option to check if a navigation map has synchronized before doing queries.
Doing queries on never synchronized navigation maps triggers certain warnings / errors.
The NavigationServer
map_changedsignal alone is too unreliable to track this.Also increases the wrap range of the map iteration id to
UINT32_MAXso long-running games and servers do not have to encounter and deal with wraps in a normal lifetime.