Fix CSGShape debug_collision_shape crash
#84338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjtxietian
reviewed
Nov 2, 2023
Fixes CSGShape debug_collision_shape crash.
smix8
force-pushed
the
csg_debug_crash
branch
from
a44117c
to
0cba21f
Compare
I am not sure. Do people benefit from a printed warning here about this? The original comment was a code comment, not directed or with useful information for engine users in particular, and now the if check basically tells the same story. |
AThousandShips
approved these changes
Nov 2, 2023
YuriSizov
approved these changes
Nov 2, 2023
|
Thanks! |
AThousandShips
added
the
cherrypick:4.2
|
Should be cherry picked, see: |
AThousandShips
added
cherrypick:4.1
akien-mga
changed the title
debug_collision_shape crash
|
Cherry-picked for 4.1.4. |
akien-mga
added
topic:3d
and removed
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CSGShape debug_collision_shape crash.
Fixes #84304
While the immediate crash source was
root_collision_shapebeing null I also do not trust a function that does not guard itself against crashes from e.g.get_world_3d()orget_global_transform(). In fact the only guard was a well-meaning comment.