Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android editor crash issue when pressing Back #84414

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Nov 3, 2023

Fix issue causing the Android editor to crash when pressing back from a running project

Fixes #79291

3.x version

Fix issue causing the Android editor to crash when pressing back from a running project
@m4gr3d m4gr3d added bug platform:android topic:editor topic:porting cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Nov 3, 2023
@m4gr3d m4gr3d added this to the 4.2 milestone Nov 3, 2023
@m4gr3d m4gr3d requested a review from a team as a code owner November 3, 2023 14:39
@YuriSizov
Copy link
Contributor

We don't benefit here from singleInstancePerTask?

@m4gr3d
Copy link
Contributor Author

m4gr3d commented Nov 3, 2023

We don't benefit here from singleInstancePerTask?

Not for the editor for a couple reasons:

  • singleInstancePerTask gives the ability to launch multiple instances of the same activity, a feature we're planning to leverage in Godot 4.3. But unlike exported games / apps, we don't have a use-case for launching multiple instances of the Editor on Android, so we prevent that by using singleTask
  • singleInstancePerTask causes the activity to always be at the root of the task. In the Editor case, this would re-introduce the issue we're solving here since, in a similar manner to singleInstance, the running project window would not be able to be in the same task as the Editor window. singleTask allows that behavior to happen

@YuriSizov YuriSizov merged commit cfc9263 into godotengine:master Nov 7, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@akien-mga akien-mga changed the title Fix Android editor crash issue Fix Android editor crash issue when pressing Back Nov 13, 2023
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

@m4gr3d m4gr3d deleted the fix_editor_crash_after_backing_from_game branch February 3, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot go back to the editor after running project in the Android editor
2 participants