Fix Camera2D frame delay (port from 3.x) #84465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeyboardDanni
force-pushed
the
deferred_camera
branch
from
479a04b
to
e21a40f
Compare
KeyboardDanni
changed the title
KeyboardDanni
force-pushed
the
deferred_camera
branch
from
e21a40f
to
734166f
Compare
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Technically not my first contribution, but thank you! |
|
Oops, my bad indeed. Well, welcome back! :D |
|
Another issues fixed by this: #73298, #89174. Might consider cherry-picking it to 4.2.2, not sure if it's "safe enough" though. Up to you @akien-mga. 😉 |
akien-mga
added
the
cherrypick:4.2
|
I guess it's worth a try? I'll cherry-pick it for 4.2.2 RC 2. |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of #46697 to the 4.x branch.
Complements #84380 by further improving the 2D pixel perfect experience.
Test project (to be used in conjunction with PR 84380): PixelPerfectTestIdle.zip
Fixes #74203 and fixes #77813.