Add tooltip for toggling favorite nodes #84619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to add a check for the same above on line 1367, as the start state of the option is based on the |
|
Wouldn't it be better to change the tooltip to e.g. "Toggle display favorite nodes.", so that it's always relevant? |
|
Agreed, that is also on the above line 1367 |
AThousandShips
changed the title
quirkylemon
force-pushed
the
favorite-node-tooltip
branch
from
0e433cb
to
f733ce6
Compare
Yeah that makes a lot more sense |
KoBeWi
approved these changes
Nov 8, 2023
akien-mga
changed the title
akien-mga
reviewed
Jan 4, 2024
quirkylemon
force-pushed
the
favorite-node-tooltip
branch
from
f733ce6
to
14b2533
Compare
Calinou
approved these changes
Jan 12, 2024
KoBeWi
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #84564
This needs translations