Save scene when saving built-in resource #84630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Nov 11, 2023
YuriSizov
approved these changes
Nov 13, 2023
YuriSizov
reviewed
Nov 13, 2023
akien-mga
approved these changes
Nov 13, 2023
KoBeWi
force-pushed
the
what_belongs_to_scene_saves_the_scene
branch
from
d82a33c
to
da55c06
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving a built-in script in script editor, the scene is saved instead.
When saving a built-in shader, an EditorFileSystemDialog appears.
I wanted to make shader editor's behavior match the script editor, but then I noticed that every resource is saved using EditorNode's
save_resource()method, I thought "why not apply this to everything?". And so I did. Now if saving any built-in resource in any editor, its scene is saved. Previously it would bring up a file dialog, as if using the Save As option.