Allow auto-generated node names in PopupMenu::add_submenu_item
#84668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Nov 9, 2023
KoBeWi
reviewed
Nov 9, 2023
YuriSizov
force-pushed
the
gui-dont-warn-when-popup-subs-are-nameless
branch
from
c5b03ad
to
edcad2e
Compare
|
Does this mean we should revert the naming of |
Explicit names are still preferred for this API. Ideally it shouldn't rely on names and just take node references, but for now we have to make do with this design. |
|
I think we can rework the system to use references internally. The current method would stay for compatibility. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #84617. After a bit of consideration, @akien-mga and I decided that it's best to allow the forbidden character. This is an ad-hoc way to address it, though exposing it on
Stringwould've been useful as well. But it's an exposed method there and I don't want to mess up things.