Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Pin Emscripten to 3.1.39 #84717

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

akien-mga
Copy link
Member

Due to #82865, newer versions can't be used for dlink-enabled Web builds. This isn't a problem for CI which doesn't use dlink, but it's clearer for users if our CI version matches the one we use for official builds.

See #84008 for an example of a user confused by our CI version.

Due to godotengine#82865, newer versions can't be used for dlink-enabled Web builds.
This isn't a problem for CI which doesn't use dlink, but it's clearer for
users if our CI version matches the one we use for official builds.
@akien-mga akien-mga added enhancement platform:web topic:buildsystem cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Nov 10, 2023
@akien-mga akien-mga added this to the 4.2 milestone Nov 10, 2023
@akien-mga akien-mga requested a review from a team as a code owner November 10, 2023 14:26
@akien-mga akien-mga merged commit 8ebb3c7 into godotengine:master Nov 10, 2023
15 checks passed
@akien-mga akien-mga deleted the ci-web-emscripten-3.1.39 branch November 10, 2023 15:02
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants