-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicating sub-scene may get two copies of internal node #84824
Conversation
Shouldn't this be determined by Then again, I doubt anyone would be intentionally owning the internal children, so the fix is probably fine anyway. |
b152e41
to
730458a
Compare
The Lines 2516 to 2518 in 41365c6
Nodes added through |
What I mean is that internal mode's only purpose is to "hide" nodes from the user (
Then they don't appear in the scene tree. I think it's more expected (or at least consistent) if they don't get duplicated. |
Previously, internal node might be mistaken for `hidden_root` and be duplicated again. Exclude those internal nodes to avoid this case, unless the owner is set intentionally.
730458a
to
f19c419
Compare
CC @KoBeWi - does this look good to go now? |
Thanks! |
Cherry-picked for 4.2.2. |
Previously, internal node might be mistaken for
hidden_root
and be duplicated again. Exclude those internal nodes to avoid this case.Fix #84803.
Bugsquad edit: Fixes #74406.