-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Donors: Change tiers to match Dev Fund, sync latest data #84884
Conversation
Should we fix the alphabetic ordering for the merges? It seems that there's two A-Z lists in Gold members. |
It's intentional, there are three sub-tiers listed under Gold currently:
We'll then update Patreon to sync the tiers on both platforms, so next update will see the removal of the <$25 tiers from that file. |
I would maybe move the |
Hm. A very personal question: this is removing me from the list of donors, but I'm still a donor, and I moved to the PayPal subscription some months ago. Did I miss a step for getting included in the list? |
@dsnopek Either you are donating below the threshold (we list people from gold member and up) or you don't have your name specified, so you are listed under anonymous. If it's neither of those, we also have reports from some users that they sporadically disappear from the list on the website (PayPal is probably bugging out), maybe you're just unlucky. |
@@ -161,7 +161,8 @@ EditorAbout::EditorAbout() { | |||
|
|||
Label *about_text = memnew(Label); | |||
about_text->set_v_size_flags(Control::SIZE_SHRINK_CENTER); | |||
about_text->set_text(String::utf8("\xc2\xa9 2014-present ") + TTR("Godot Engine contributors") + "." + | |||
about_text->set_text( | |||
String::utf8("\xc2\xa9 2014-present ") + TTR("Godot Engine contributors") + "." + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's been like that before, but I find it weird that we translate that part specifically, but not, say, "present". 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also dates themselves are subject to translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could create a PR afterwards to translate that part of the string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good.
@YuriSizov I see now on https://fund.godotengine.org/ that I was supposed to send an email to get my name listed. Per my PayPal history, I moved my subscription from Patreon to PayPal back in March, and I guess I wasn't aware of that requirement. I've just sent the email, so I'll hopefully get included in the next update. :-) |
9ecf57c
to
fee03d3
Compare
The new list includes all donors listed on fund.godotengine.org, together with the ones still on Patreon on matching tiers. We haven't yet updated Patreon tiers to match the Dev Fund, so donors who used to be listed under "Silver donors" are now grandfathered under the "Gold members" category from the Dev Fund.
fee03d3
to
ff5ac86
Compare
@dsnopek Added you back here, until Emi adds you to the fund :) |
Added on the dev fund! |
Cherry-picked for 4.1.4. |
Cherry-picked for 3.6. |
Cherry-picked for 3.5.4. |
The new list includes all donors listed on fund.godotengine.org, together with the ones still on Patreon on matching tiers.
We haven't yet updated Patreon tiers to match the Dev Fund, so donors who used to be listed under "Silver donors" are now grandfathered under the "Gold members" category from the Dev Fund.
simplescreenrecorder-2023-11-14_14.39.48.mp4