Replace memory allocation point of ValueTrack correctly in AnimationMixer #85001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
requested changes
Nov 17, 2023
alesliehughes
force-pushed
the
anim_mixer_leak
branch
from
8a4110e
to
5f48021
Compare
TokageItLab
requested changes
Nov 17, 2023
|
I'll fix the commit up shortly. Didn't mean to create a second commit. |
TokageItLab
approved these changes
Nov 17, 2023
|
Okay, please squash later. |
alesliehughes
force-pushed
the
anim_mixer_leak
branch
2 times, most recently
from
9beb3c0
to
33e253d
Compare
TokageItLab
changed the title
alesliehughes
force-pushed
the
anim_mixer_leak
branch
from
33e253d
to
2f43f4a
Compare
akien-mga
added
the
cherrypick:4.2
|
@alesliehughes It's not obvious to me what this does, could you add more details on what the bug is in the PR description? |
When a animation track doesn't have an keys, it's possible that we leak memory due the ERR_CONTINUE_MSG macro usage. By checking the error condition first, we avoid a allocated and thus the leak. I'll update the patch with the above. |
…ixer When a animation track doesn't have an keys, it's possible that we leak memory due the ERR_CONTINUE_MSG macro usage. By checking the error condition first, we avoid a allocation and thus the leak.
alesliehughes
force-pushed
the
anim_mixer_leak
branch
from
2f43f4a
to
ea84eff
Compare
akien-mga
approved these changes
Dec 11, 2023
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.