Workaround (temporarily) ScriptServer mutex issues #85165
Conversation
|
Test build made with mingw-gcc of 4.2.rc1 + this PR applied: https://downloads.tuxfamily.org/godotengine/testing/Godot_v4.2-rc1_mingw-mutex-fixup.exe.zip |
|
Can't reproduce #78734, but I can't reproduce it anymore prior to any of the fixes, so I can't tell for sure. |
|
Unfortunately, #85105 doesn't appear to be fixed. I can still trigger the crash exactly the same way, although I did get it to hang for a bit and then proceed successfully once or twice. So, better? There is definitely a change in behavior. But ultimately, no, doesn't fix it. Edit: Just to be sure I retested #85039 and it works perfectly fine, just like my own MSVC builds of |
|
In further testing, I'm also able to reproduce #78734 now. It's very consistent, although it doesn't always unravel the same way. Sometimes it loads just fine, sometimes it hicks up and crashes immediately, and sometimes it goes for many frames before giving up. Although sometimes it makes it through, very very slowly. Probably just a freakishly low chance, but sometimes dice roll in your favor 🙃 With this fix the behavior is consistent with what I've described in the previous comment. The crash is still there, but sometimes it hangs and tries to slowly process something. And the visual indication of the hang is exactly the same here as in #85105 with this PR. Every second or so there is a spinning indicator on the cursor which quickly disappears. So like it processes for half a second and waits, processes and waits. The #85039 PR consistently resolves the issue again, the loading in #78734 happens as expected. |
|
Superseded by #85039. |
This is an intended workaround to some issues due to some underlying MinGW bug coupled with #84657. #85039 aims to address them for good, but so late in the release cycle we need a compromise solution.
Fixes #78734.
Fixes #85105.