-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer identifiers annotated type if assigned type is incompatible to it #85224
Merged
YuriSizov
merged 1 commit into
godotengine:master
from
HolonProduction:identifier-type-prefer-annotated
Jan 24, 2024
Merged
Prefer identifiers annotated type if assigned type is incompatible to it #85224
YuriSizov
merged 1 commit into
godotengine:master
from
HolonProduction:identifier-type-prefer-annotated
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HolonProduction
force-pushed
the
identifier-type-prefer-annotated
branch
from
December 21, 2023 22:47
a265ee1
to
cd7ce3a
Compare
vnen
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vnen
requested changes
Jan 17, 2024
HolonProduction
force-pushed
the
identifier-type-prefer-annotated
branch
from
January 17, 2024 21:32
cd7ce3a
to
0203b3c
Compare
vnen
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Sorry for the delay in reviewing it
Should we consider #78929 superseded? |
Thanks! |
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clashes with the PR #78929
Fixes partially #74888
Fixes partially #71296
Fixes partially #78454
Fixes #78860
Fixes #78820
Fixes partially #86172
Fixes #86513
Fixes #86871
A small self contained example demonstrating the problem:
Obviously the example isn't valid GDScript, but in more complex situations like #74888 the incompatible assignment might result from an issue with interfering the type of the assignment which might still be valid at runtime. In such cases we should respect the type that the user specified.
Implementation detail:
TODO:
it currently only works with local variables but as Autocompletion fromDoneget_node()
still does not work for some cases #86172 shows it can also happen with class properties