Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Navigation] Do not use travel cost for minimum when re-selecting end point #85253

Conversation

sandygk
Copy link
Contributor

@sandygk sandygk commented Nov 23, 2023

This one liner PR fixes the bug, explained here #85238

Here is a screenshot of the same scene mentioned in the bug, but with the fix applied, please read the attached bug for an explanation of the issue and for a minimal project to test.

image

Bugsquad edit:

@smix8 smix8 modified the milestones: 4.x, 4.3 Nov 28, 2023
@AThousandShips AThousandShips changed the title Use min distance to target to re-select end point [Navigation] Do not use travel cost for minimum when re-selecting end point Nov 28, 2023
@AThousandShips
Copy link
Member

AThousandShips commented Nov 28, 2023

Could you update your commit message (using git commit --amend and then pushing with git push --force) to be more descriptive, the minimum was always used, the change is in the value

The current title or similar would be good

@sandygk sandygk force-pushed the fix-reachable-polygon-closest-to-end-point branch from 3065311 to 11e63d2 Compare November 28, 2023 12:26
@sandygk
Copy link
Contributor Author

sandygk commented Nov 28, 2023

@AThousandShips done :)

@YuriSizov YuriSizov merged commit d4806d2 into godotengine:master Dec 19, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks, and congrats on your first merged Godot contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants