-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add 4.2-stable.expected file for GDExtension compatibility checks #85748
CI: Add 4.2-stable.expected file for GDExtension compatibility checks #85748
Conversation
Should the 4.1 file be renamed like the 4.0 one was? |
96017c7
to
7644db9
Compare
We have the following errors:
The
CC @RedworkDE |
Could it be related in some way to that the version tag is updated after that? The The relevant file in |
The script downloads the json from the godot-cpp tag of the version in the filename (first one if it's a range), so it should be comparing 4.3-dev (this PR) with 4.2-stable. |
This comment was marked as outdated.
This comment was marked as outdated.
7644db9
to
627530a
Compare
627530a
to
cff4af0
Compare
OS::get_singleton()->set_exit_code(valid ? EXIT_SUCCESS : EXIT_FAILURE); | ||
return false; | ||
if (validate_extension_api) { | ||
Engine::get_singleton()->set_editor_hint(true); // "extension_api.json" should always contains editor singletons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the issue that singletons/EditorInterface
was missing in the API generated by --validation-extension-api
, thus failing the comparison with the file generated by --dump-extension-api
, which uses editor hint.
The rest is just a cosmetic change to keep GDExtension stuff visually grouped together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text at this file should be changed to be in sync with the 4.0->4.1 file. I updated #76560 to include this.
Adds the editor hint for
--validate-extension-api
to match--dump-extension-api
, otherwise we're missing the EditorInterface singleton.