C#: Implement function to throw on null pointers #85975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulsntos
approved these changes
Dec 16, 2023
modules/mono/glue/GodotSharp/GodotSharp/Core/NativeInterop/ExceptionUtils.cs
Outdated
Show resolved
Hide resolved
modules/mono/glue/GodotSharp/GodotSharp/Core/NativeInterop/ExceptionUtils.cs
Outdated
Show resolved
Hide resolved
• Specifically: checks if ptr == IntPtr.Zero
Repiteo
force-pushed
the
c#-null-ptr-exception
branch
from
bdc30c1
to
a0db883
Compare
|
Thanks! |
|
Builds for the .NET version on the build server fail with this error, which I believe is related to this PR: See also #82983. Fix: #86373. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically: checks if a passed
IntPtris equal toIntPtr.Zero. Utilizes the same syntax asArgumentNullException.ThrowIfNull; only the argument needs to be passed, with the argument name being automatically pulled via theCallerArgumentExpressionattribute1. In addition to implementing this on the generated NativeCalls files, minor changes were also made tobindings_generator.cppin order to give the resulting file proper formatting.Footnotes
https://learn.microsoft.com/en-us/dotnet/api/system.runtime.compilerservices.callerargumentexpressionattribute ↩