Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discrete key retrieval method after start #86227

Conversation

TokageItLab
Copy link
Member

Fixes #86147.

Immediately after playback, the key must be obtained in EXACT mode.

This will also solve part of the problem that #85950 mentions.

@TokageItLab TokageItLab added bug regression topic:animation cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Dec 16, 2023
@TokageItLab TokageItLab added this to the 4.3 milestone Dec 16, 2023
@TokageItLab TokageItLab requested a review from a team as a code owner December 16, 2023 05:25
@TokageItLab TokageItLab force-pushed the fix-discrete-key-retrieval-after-start branch 3 times, most recently from 9c6c350 to 9ba3fde Compare December 16, 2023 05:47
@NewDefectus
Copy link
Contributor

+1. I wouldn't mind having this be included in a 4.2.x release

@TokageItLab TokageItLab force-pushed the fix-discrete-key-retrieval-after-start branch from aeaff82 to b438e28 Compare January 2, 2024 17:29
@akien-mga akien-mga merged commit 2d6d726 into godotengine:master Jan 3, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

@TokageItLab TokageItLab deleted the fix-discrete-key-retrieval-after-start branch February 14, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnimationPlayer resume animation by play() after pause() make call method track called function call again
5 participants