Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Remove deprecated LaunchImages support and switch to Storyboard by default. #86312

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Dec 18, 2023

Seems like use of deprecated LaunchImages is causing app to be unable to use native resolution and iPhone 6+ type UI scaling is applied.

Fixes #82730

@bruvzg
Copy link
Member Author

bruvzg commented Dec 18, 2023

Note: storyboards are supported in iOS 8 (and later), so there's no need to keep LaunchImages for compatibility.

@bruvzg bruvzg marked this pull request as ready for review December 18, 2023 20:40
@bruvzg bruvzg requested review from a team as code owners December 18, 2023 20:40
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense on my end (although I don't have a device to test this). Code looks good to me at a glance.

@akien-mga akien-mga merged commit 27a9119 into godotengine:master Jan 3, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Mar 9, 2024
akien-mga added a commit to akien-mga/godot that referenced this pull request Mar 9, 2024
LaunchImages are deprecated, and Storyboard is supported on all currently
supported iOS versions, so this should be the default.

LaunchImages support was removed in 4.3 with godotengine#86312.
@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Mar 10, 2024
akien-mga added a commit to akien-mga/godot that referenced this pull request Mar 11, 2024
LaunchImages are deprecated, and Storyboard is supported on all currently
supported iOS versions, so this should be the default.

LaunchImages support was removed in 4.3 with godotengine#86312.

(cherry picked from commit 91c5d1e)
@owlnewworlds
Copy link

Hello everyone,

Does this issue is fixed in Godot 4.3 beta 3 ? I'm trying my first iOS exports and my game isn't fullscreen/scaled properly.

addmix pushed a commit to addmix/godot that referenced this pull request Sep 6, 2024
LaunchImages are deprecated, and Storyboard is supported on all currently
supported iOS versions, so this should be the default.

LaunchImages support was removed in 4.3 with godotengine#86312.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iPhone screen size is wrongly detected on Godot, leading to blurriness/jagginess
4 participants