-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Polygon2D to Skeleton2D transform calculation #86557
Fix Polygon2D to Skeleton2D transform calculation #86557
Conversation
Sorry, it's a shame to missing the transform multiply rule XD. |
Checked my test cases with this fix, they all looks fine. As auther said 2d to 3d transform should be take care like this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Thanks! |
Cherry-picked for 4.2.2. |
Cherry-picked for 4.1.4. |
Fixes incorrect calculation made in #84451 (cc @ShirenY).
Fixes #86390.
Before/after examples:
MRP from #86390
out1pre.mp4
out1post.mp4
MRP from #86547
out2pre.mp4
out2post.mp4