-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiny fix for lightmapper DDA #86583
Tiny fix for lightmapper DDA #86583
Conversation
reduz
commented
Dec 28, 2023
•
edited
Loading
edited
- Ensures only one axis advances at a time
- This fixes extremely corner cases where the DDA may skip over geometry
- As a bonus, clarify to the user that splitting into more meshes may improve the texture size limit.
565c17e
to
8fa77d8
Compare
8fa77d8
to
200b1cf
Compare
Error while building
|
200b1cf
to
d4ed3d4
Compare
Looks they are working much better now. I tried on sponza and in the TPS demo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Using lessThanEqual
could return multiple channels where the channels are equal. We can't move to lessThan
as we could end up with zero channels and then we are stuck.
You just need to remove the old line before this is ready to merge.
- Ensures only one axis advances at a time - This fixes extremely corner cases where the DDA may skip over geometry
d4ed3d4
to
caef2be
Compare
This should now be ready |
Thanks! |