Godot 3.0 primitives as resources for use with MeshInstance #8661

BastiaanOlij · 2017-05-06T00:25:25Z

I've ported PR #8578 to Godot 3 and as suggested by @reduz changed the implementation to resources subclassed from Mesh instead of Nodes.

There are a few small fixes in this, I had calculated the normals of the cylinders wrong and you now have more freedom on the prism to move the top of the triangle in any position between left (0.0) and right (1.0).

Currently my build of Godot 3 crashes on creating materials so I have no been able to test if there are any issues with the texturing and I have no updated my test project to Godot 3.0 yet as a result.

BastiaanOlij · 2017-05-06T00:28:15Z

I will also be adding more objects in a later build, took me all morning to port this and I am running out of battery :)

One thing I do not like, and @reduz I hope you can make some suggestions here on how I can improve this, is that I rebuild the mesh on every property change. Is there a way to postpone this until the mesh is needed for the first time since the last property change?

RameshRavone · 2017-05-06T04:48:19Z

STATIC_CHECKS: Clang-format is not happy 😄

BastiaanOlij · 2017-05-06T07:28:44Z

Yeah Clang and I still need to learn to get along :) I did manage to get it installed the other day so I need to start playing with it and get it to go over my sourcecode before I commit it :)

nunodonato · 2017-05-06T07:54:47Z

@BastiaanOlij check https://travis-ci.org/godotengine/godot/jobs/229333800 it tells you what you need to change to conform to clang style

BastiaanOlij · 2017-05-06T08:08:35Z

@nunodonato I actually got clang-format working (I think) so my next commit should fingers crossed have all those issues fixed :)
I tried doing it by hand for one of my other PRs and its annoying:)

BastiaanOlij · 2017-05-06T08:32:33Z

Ok, hopefully clang will love me now. I've also added a 3D plane which you can set segments for, together with a vertex shader that would make an ideal candidate for rendering height maps. I've also added a capsule object. Haven't been able to test if the textures are ok yet, recompiling on latest master atm, hoping it'll fix the crashing issue...

akien-mga · 2017-05-07T13:07:44Z

modules/primitives/register_types.cpp

+
+void register_primitives_types() {
+
+  ClassDB::register_class<Capsule3D>();


Hm, you don't want clang-format to like you, do you? :p

akien-mga · 2017-05-07T13:08:59Z

Still got a couple things to fix to make clang-format happy: https://travis-ci.org/godotengine/godot/jobs/229399863
You should really look into that precommit hook to let it do formatting automatically :)

BastiaanOlij · 2017-05-07T22:41:48Z

@akien-mga , how weird, I thought I had ran it on there, I must have made some last minute changes that caused something to misalign.

Yeah indeed, I need to figure out the precommit thingy, I was happy enough to get clang-format to get installed :)

BastiaanOlij · 2017-05-08T04:07:43Z

Yeah! all green ticks:)

BastiaanOlij · 2017-06-10T01:18:07Z

@reduz I had a quick look this morning about changing this over on the new structure as you suggested in #8578 , any suggestions of a class to look at that gives a bit of an idea of how the new approach works? Looks like you retired quadmesh? :)

I'll keep puzzling away in the mean while.

reduz · 2017-06-10T02:29:36Z

I can rewrite quadmesh for reference

…

On Fri, Jun 9, 2017 at 10:18 PM, Bastiaan Olij ***@***.***> wrote: @reduz <https://github.com/reduz> I had a quick look this morning about changing this over on the new structure as you suggested in #8578 <#8578> , any suggestions of a class to look at that gives a bit of an idea of how the new approach works? Looks like you retired quadmesh? :) I'll keep puzzling away in the mean while. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8661 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF-Z2885sAS5RA4pI7Yx9di1eH05WCK0ks5sCe7WgaJpZM4NSjSL> .

BastiaanOlij · 2017-06-10T05:08:29Z

@reduz only if its not too much trouble else I'm sure we'll catch eachother on IRC. Just need to get an idea of what the new structure is like.

edit, looks like the dirty way to implement it is to subclass ArrayMesh instead of Mesh. But I get a feeling the point is to implement the virtual methods on Mesh instead and just returning the single surface information that we generate from the properties set by the user? Then find some way to tell Godot the mesh has changed when the properties are changed which I'm guessing is done by these three methods:

	_clear_triangle_mesh();
	_change_notify();
	emit_changed();

(clear the previously generated mesh, set notify status and send signals?)

BastiaanOlij · 2017-06-10T13:52:48Z

BROKEN -- Nearly all removed, will be rectified shortly

Just committed first attempt at changing implementation over to new approach. just working on cube3d atm which has been renamed to cubemesh.

It doesn't work yet, I'm not sure what is missing but I have a feeling _update isn't being called at the right time. @reduz if you wouldn't mind having a closer look, I must be missing a step somewhere but its getting late and my mind is giving up :)

Once I have cubemesh working I'll port all the others over.

bojidar-bg · 2017-06-13T10:12:01Z

scene/resources/cubemesh.cpp

@@ -0,0 +1,396 @@
+/*************************************************************************/
+/*  cube3d.cpp                                                           */


Yet another wrong filename in the header 😉

Lolz, yeah after discussing with reduz we felt renaming this to cubemesh made more sense. The originals were all called something3d

But I'm far more interested in the golden tip that allows me to figure out what I'm doing wrong and why I'm not actually getting a cube created! :)

reduz · 2017-06-13T12:17:03Z

scene/resources/cubemesh.cpp

+	arr[VS::ARRAY_INDEX] = indices;
+
+	// out with the old
+	while (VisualServer::get_singleton()->mesh_get_surface_count(mesh) > 0) {


Any request of info from VisualServer (in this case mesh_get_surface_count()) stalls the rendering thread, so it's better avoided

BastiaanOlij · 2017-06-13T13:40:56Z

Ok, we have a working cubemesh!! :)

I'll start working on converting the other primitives later in the week, should be pretty smooth sailing from here on. One of the suggestions made on IRC was to add a class in between Mesh and these primitives shapes as there will be some overlapping code. Not sure what a good name would be, suggestions are welcome :)

Zireael07 · 2017-06-13T14:48:11Z

PrimitiveMesh sound good as a class name?

bojidar-bg · 2017-06-13T18:05:14Z

I guess GeneratedMesh is better?

BastiaanOlij · 2017-06-14T04:03:18Z

The thing I'm most worried about regarding the name is that it has the potential to put people on the wrong foot. The thing that would make these classes easy to implement with the largest amount of common code in its base class would be to make the assumption any subclass will always have a single surface and single material. The subclass then simply implements the code that generates this surface.

GeneratedMesh suggests it would be able to do more. If I were to implement a dual contouring algorithm to generate the mesh for a terrain section (something on my wishlist of things to do) I might wish to create multiple surfaces.

The opposite goes for PrimitiveMesh, the base class has the potential to be used for more then just generating primitive shapes.

I'm probably overthinking it ;)

BastiaanOlij · 2017-06-14T14:03:28Z

4 out of the original 6 mesh types have now been converted to the new approach.

@reduz asked to also add the original QuadMesh to this. PlaneMesh possibly replaces this as it can create a Quad if you subdivide each side by 1.

bojidar-bg · 2017-06-14T14:39:42Z

Would the Quad and the TestCube nodes be obsoleted by the change?

reduz · 2017-06-14T14:58:35Z

Yes they should be removed

…

On Jun 14, 2017 11:39 AM, "Bojidar Marinov" ***@***.***> wrote: Would the Quad and the TestCube nodes be obsoleted by the change? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8661 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF-Z21A80mj-Zf0oNoRZhD9zRj381SN_ks5sD_C6gaJpZM4NSjSL> .

BastiaanOlij · 2017-06-15T13:51:35Z

I think it's all done. Note that there is a test project to test this with here:

https://github.com/BastiaanOlij/TestPrimitives

Adds the following resources: - CapsuleMesh: a capsule object - CubeMesh: a cube that can be subdivided - CylinderMesh: a cylinder - PlaneMesh: a horizontal plane that can be subdivided - PrismMesh: a prism shape - SphereMesh: a sphere - QuadMesh: reintroduction of the original quadmesh Removes the old Quad and TestCube nodes

zatherz · 2017-08-17T22:31:32Z

Note: test project moved to https://github.com/BastiaanOlij/godot3_test_projects/tree/master/TestPrimitives

rraallvv · 2017-11-12T14:14:34Z

Does anyone know of a demo video showing off this feature? Thanks.

Zireael07 · 2017-11-12T14:16:21Z

@rraallvv: you don't really need a demo video. Create a mesh instance node, click the arrow next to mesh: and voila, you can see all the primitives available.

rraallvv · 2017-11-12T14:21:37Z

@Zireael07 I see... maybe it isn't available for 2.1, I'll try 3.0 then, thanks.

Zireael07 · 2017-11-12T14:24:32Z

This is only for 3.0, yes.

aaronfranke · 2018-01-16T23:58:12Z

The Capsule primitive (and collider) are the wrong orientation by default. #5813

BastiaanOlij force-pushed the primitives_3.0 branch from a27a36f to 2eb5653 Compare May 6, 2017 08:29

BastiaanOlij force-pushed the primitives_3.0 branch from 2eb5653 to f80a861 Compare May 6, 2017 09:23

akien-mga added feature proposal topic:core topic:editor labels May 7, 2017

akien-mga added this to the 3.0 milestone May 7, 2017

akien-mga reviewed May 7, 2017

View reviewed changes

BastiaanOlij force-pushed the primitives_3.0 branch from f80a861 to 25f404d Compare May 7, 2017 22:53

BastiaanOlij mentioned this pull request Jun 10, 2017

Added a number of primitive objects #8578

Closed

BastiaanOlij force-pushed the primitives_3.0 branch from 25f404d to cff0a6c Compare June 10, 2017 13:48

BastiaanOlij force-pushed the primitives_3.0 branch 3 times, most recently from bbdb1d1 to 147ca82 Compare June 11, 2017 13:32

bojidar-bg reviewed Jun 13, 2017

View reviewed changes

reduz reviewed Jun 13, 2017

View reviewed changes

BastiaanOlij force-pushed the primitives_3.0 branch from 147ca82 to 8830f97 Compare June 13, 2017 13:38

BastiaanOlij force-pushed the primitives_3.0 branch 2 times, most recently from 46dce46 to a46285b Compare June 14, 2017 14:00

bojidar-bg mentioned this pull request Jun 14, 2017

Model for testing materials in Godot #9118

Closed

BastiaanOlij force-pushed the primitives_3.0 branch from a46285b to cfef945 Compare June 15, 2017 13:51

BastiaanOlij force-pushed the primitives_3.0 branch 2 times, most recently from 04fcbec to 8273cf3 Compare June 16, 2017 11:32

BastiaanOlij force-pushed the primitives_3.0 branch from 8273cf3 to 9483613 Compare June 16, 2017 11:40

akien-mga merged commit 9ff7bd4 into godotengine:master Jun 16, 2017

akien-mga mentioned this pull request Jun 16, 2017

Add more primitives to the editor for rapid prototyping #1381

Closed

BastiaanOlij deleted the primitives_3.0 branch June 16, 2017 12:00

akien-mga mentioned this pull request Mar 15, 2018

Add create object menu for meshes #12767

Closed

aaronfranke mentioned this pull request Nov 22, 2018

Add Shape2D node #6750

Closed

tyhal mentioned this pull request Nov 10, 2019

Big list of reference material tyhal/godot-leap-bound#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Godot 3.0 primitives as resources for use with MeshInstance #8661

Godot 3.0 primitives as resources for use with MeshInstance #8661

BastiaanOlij commented May 6, 2017

BastiaanOlij commented May 6, 2017

RameshRavone commented May 6, 2017

BastiaanOlij commented May 6, 2017

nunodonato commented May 6, 2017

BastiaanOlij commented May 6, 2017

BastiaanOlij commented May 6, 2017

akien-mga May 7, 2017

akien-mga commented May 7, 2017

BastiaanOlij commented May 7, 2017

BastiaanOlij commented May 8, 2017

BastiaanOlij commented Jun 10, 2017

reduz commented Jun 10, 2017 via email

BastiaanOlij commented Jun 10, 2017 •

edited

Loading

BastiaanOlij commented Jun 10, 2017 •

edited

Loading

bojidar-bg Jun 13, 2017

BastiaanOlij Jun 13, 2017

reduz Jun 13, 2017

BastiaanOlij commented Jun 13, 2017

Zireael07 commented Jun 13, 2017

bojidar-bg commented Jun 13, 2017

BastiaanOlij commented Jun 14, 2017

BastiaanOlij commented Jun 14, 2017

bojidar-bg commented Jun 14, 2017

reduz commented Jun 14, 2017 via email

BastiaanOlij commented Jun 15, 2017

zatherz commented Aug 17, 2017

rraallvv commented Nov 12, 2017 •

edited

Loading

Zireael07 commented Nov 12, 2017

rraallvv commented Nov 12, 2017

Zireael07 commented Nov 12, 2017

aaronfranke commented Jan 16, 2018


		void register_primitives_types() {

		ClassDB::register_class<Capsule3D>();

		@@ -0,0 +1,396 @@
		/*************************************************************************/
		/* cube3d.cpp */

Godot 3.0 primitives as resources for use with MeshInstance #8661

Godot 3.0 primitives as resources for use with MeshInstance #8661

Conversation

BastiaanOlij commented May 6, 2017

BastiaanOlij commented May 6, 2017

RameshRavone commented May 6, 2017

BastiaanOlij commented May 6, 2017

nunodonato commented May 6, 2017

BastiaanOlij commented May 6, 2017

BastiaanOlij commented May 6, 2017

akien-mga May 7, 2017

Choose a reason for hiding this comment

akien-mga commented May 7, 2017

BastiaanOlij commented May 7, 2017

BastiaanOlij commented May 8, 2017

BastiaanOlij commented Jun 10, 2017

reduz commented Jun 10, 2017 via email

BastiaanOlij commented Jun 10, 2017 • edited Loading

BastiaanOlij commented Jun 10, 2017 • edited Loading

bojidar-bg Jun 13, 2017

Choose a reason for hiding this comment

BastiaanOlij Jun 13, 2017

Choose a reason for hiding this comment

reduz Jun 13, 2017

Choose a reason for hiding this comment

BastiaanOlij commented Jun 13, 2017

Zireael07 commented Jun 13, 2017

bojidar-bg commented Jun 13, 2017

BastiaanOlij commented Jun 14, 2017

BastiaanOlij commented Jun 14, 2017

bojidar-bg commented Jun 14, 2017

reduz commented Jun 14, 2017 via email

BastiaanOlij commented Jun 15, 2017

zatherz commented Aug 17, 2017

rraallvv commented Nov 12, 2017 • edited Loading

Zireael07 commented Nov 12, 2017

rraallvv commented Nov 12, 2017

Zireael07 commented Nov 12, 2017

aaronfranke commented Jan 16, 2018

BastiaanOlij commented Jun 10, 2017 •

edited

Loading

BastiaanOlij commented Jun 10, 2017 •

edited

Loading

rraallvv commented Nov 12, 2017 •

edited

Loading