[3.x] Rewrite most of Resource's documentation #86642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
force-pushed
the
3.x-doc-peeves-resourceful-uh-oh-stinky
branch
2 times, most recently
from
9157b29
to
1b91208
Compare
No, we shouldn't change the 3.x API at this stage. The branch is in maintenance mode and any API change won't be notice by users, and only risks affecting existing users of the feature. |
Mickeon
force-pushed
the
3.x-doc-peeves-resourceful-uh-oh-stinky
branch
from
1b91208
to
2985890
Compare
|
There you go. Removed the deprecation note |
Mickeon
force-pushed
the
3.x-doc-peeves-resourceful-uh-oh-stinky
branch
from
2985890
to
1dee97a
Compare
|
Double-checked the examples. |
|
May someone take a glance at this again? |
akien-mga
approved these changes
Jan 26, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-docs#6479 (Happy anniversary).
Kind of a 3.x version of #67072.
This PR brings the Resource's class reference in line with master's, with a few tweaks to suit 3.x:
get_rid()are different.Now, what to do with
setup_local_to_scene? Should it be deprecated here, too?