-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow opening scenes with missing scene dependency #86781
Allow opening scenes with missing scene dependency #86781
Conversation
It would be nice if InstancePlaceholder were capable of doing that. |
@Mickeon Something for a followup PR I think? |
Yeah. For the focus of this PR, changing the tooltip to not blatantly lie may be good enough. |
Perhaps MissingNode could have a Dictionary containing NodePaths pointing to the lost properties and values. When loading a PackedScene in the editor, it is detected and rebuilt if possible, or left as is. It sounds extremely hacky but... Yeah. |
a716162
to
7a9f940
Compare
7a9f940
to
39a8d77
Compare
I think this looks good but keep in mind sometimes dependencies fail to open because they miss resources and they should still be openable anyway, so maybe this should only really be used in case the scene is not found. |
Will need a rebase. |
39a8d77
to
54d96cd
Compare
Rebased. Seems like someone added a description for |
give me a second before merging this, I want to check something |
Alright, I think its good to merge, but I think what we still need to have an option to recursively fix dependencies on subresources that don't load because of this. |
54d96cd
to
be4cbee
Compare
Thanks! |
I tried to address something like this a while ago aswell, and while it was more of a hackfix (#75103), i think not losing nodes is still the actual desire, as some sources might just have been renamed or moved; where it shouldn't be assumed they are actually missing. |
When a scene has instances of scenes that no longer exist in the project, you won't be able to open them, with the well-known "Scene invalid/corrupt" error. This PR fixes that.
QdRyle2wEe.mp4
However, while it technically works (i.e. you can open the scene), it could use some improvements. I wanted it to at least display path of the missing scene, but I wasn't sure how to obtain it (in the video it shows as TODO). Also, contrary to what the tooltip says, saving the scene will result in data loss. The instance will be gone and any editable children data is lost. It would be nice to preserve at least the instance; if it's not possible/too difficult, changing the tooltip would be fine for now too.