Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse the names of children of TabContainers on POT generation #86878

Merged

Conversation

YeldhamDev
Copy link
Member

TabContainer makes use of its children's names to title its tabs, so those should be translated as well. If a child has auto_translate disabled, it will be skipped, as well as all children if the TabContainer itself disabled it.

@YeldhamDev YeldhamDev added this to the 4.3 milestone Jan 6, 2024
@YeldhamDev YeldhamDev requested a review from a team January 6, 2024 14:11
@KoBeWi
Copy link
Member

KoBeWi commented Jan 8, 2024

This can generate false positives if set_tab_title() is used.

@YeldhamDev
Copy link
Member Author

YeldhamDev commented Jan 8, 2024

@KoBeWi Then the user can toggle auto_translate off in the respective node (or the container itself), as explained above.

@akien-mga akien-mga merged commit fa3477f into godotengine:master Jan 15, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YeldhamDev YeldhamDev deleted the tabcontainer_pot_generation branch January 15, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants