Add tests/python_build to clang-format pre-commit hook ignore list
#87000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @akien-mga, you seem to have been maintaining these :) |
|
CI fails because of:
That's a new one... |
|
Looks like GitHub is having server problems again |
akien-mga
changed the title
tests/python_build to clang-format pre-commit hook ignore list
akien-mga
reviewed
Jan 9, 2024
It had been ignored by misc/scripts/clang_format.sh since 388d35b but not the hook.
akx
force-pushed
the
pre-commit-clang-format-ignore-fix
branch
from
4b9abe5
to
de7133e
Compare
|
Gentle ping, @akien-mga? |
akien-mga
approved these changes
Feb 9, 2024
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It had been ignored by misc/scripts/clang_format.sh since 388d35b but not the hook; running the hook on all files yields changes in GLSL files in that directory.