Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DX12 build on older MSVC versions, fix missing PIX include. #87206

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Fix DX12 build on older MSVC versions, fix missing PIX include. #87206

merged 1 commit into from
Jan 16, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jan 15, 2024

@bruvzg bruvzg added this to the 4.3 milestone Jan 15, 2024
RandomShaper
RandomShaper approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@RandomShaper RandomShaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, TAICS*.

  • TAICS: That's all I can say.

@bruvzg bruvzg mentioned this pull request Jan 15, 2024
Closed
@akien-mga akien-mga merged commit 7d17496 into godotengine:master Jan 16, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@RandomShaper RandomShaper RandomShaper approved these changes

Assignees
No one assigned
Labels
bug platform:windows topic:porting
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@bruvzg @akien-mga @RandomShaper