Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android dependencies for the project #87346

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Jan 18, 2024

Time of the year for another broad Android dependencies update!

  • Update Android gradle plugin version from 7.2.1 to 8.2.0
  • Update gradle version from 7.4.2 to 8.2
  • Update target SDK from 33 to 34
  • Update build tools version from 33.0.2 to 34.0.0
  • Update kotlin version from 1.7.0 to 1.9.20
  • Update Android fragment version from 1.3.6 to 1.6.2
  • Update AndroidX window version from 1.0.0 to 1.2.0

There have been quite a few deprecation and api updates in the gradle buildsystem so this PR updates the gradle build logic where needed to comply.
I've done my best to validate that no regressions were introduced, but I'd appreciate additional testing for thoroughness.

Fixes #87072 for the master branch; need to evaluate if this is safe to backport to 3.x

Notes:

  • The ndk version was not updated since the new AGP and gradle versions still support the version we use. Due to the changes from ndk 23 to 25, its update will be done in its own separate PR
  • WARNING:The option setting 'android.enableResourceOptimizations=false' is deprecated. #53749 is still a valid issue as the deprecation for android.enableResourceOptimizations was pushed to AGP version 9+. I have a few ideas for how to deal with this when it's fully deprecated but this will require follow-up discussions.

@JekSun97
Copy link

I think this is an important update for the future, thanks!

- Update Android gradle plugin version from 7.2.1 to 8.2.0
- Update gradle version from 7.4.2 to 8.2
- Update target SDK from 33 to 34
- Update build tools version from 33.0.2 to 34.0.0
- Update kotlin version from 1.7.0 to 1.9.20
- Update Android fragment version from 1.3.6 to 1.6.2
- Update AndroidX window version from 1.0.0 to 1.2.0
@m4gr3d m4gr3d force-pushed the android_dependencies_updates branch from 9d6c5d6 to e04a387 Compare January 18, 2024 18:35
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, but changes look good. Should be good to go for our next dev snapshot.

@YuriSizov YuriSizov changed the title Android dependencies updates Update Android dependencies for the project Jan 22, 2024
@YuriSizov YuriSizov merged commit 2ee8f46 into godotengine:master Jan 22, 2024
16 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@tokengamedev
Copy link

Will there be separate PR for 4.2 or will this be merged to 4.2 branch?

@m4gr3d
Copy link
Contributor Author

m4gr3d commented Jan 25, 2024

@YuriSizov @akien-mga We may consider cherry-picking this for 4.2.3 if it doesn't introduce any issues in the next 4.3 dev snapshot.

@YuriSizov YuriSizov added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 25, 2024
@m4gr3d m4gr3d deleted the android_dependencies_updates branch January 29, 2024 16:51
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 12, 2024
@Zyrean5
Copy link

Zyrean5 commented Apr 20, 2024

Can you update the documentary for the correct versions also?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle warning during export to Android (Gradle version too old for compileSdk 33)
6 participants