Fix selection regression in EditorHelpSearch

[AThousandShips]

Investigated clearing the selection details on removing a TreeItem but think that's a bit of a larger investigation so keeping this restricted

The bug was caused by the removed item being currently selected, and then failing on re-select here:

godot/scene/gui/tree.cpp

Lines 2615 to 2617 in 0bcc0e9

	if (!r_in_range && &selected_cell == &c) {
	if (!selected_cell.selected || allow_reselect) {
	selected_cell.selected = true;

• Fixes: Open button gets disabled for some help classes when searching #87472

[AThousandShips]

My alternative fix was:

diff --git a/scene/gui/tree.cpp b/scene/gui/tree.cpp
index c67c3cd98d..fa22313d14 100644
--- a/scene/gui/tree.cpp
+++ b/scene/gui/tree.cpp
@@ -121,6 +121,9 @@ void TreeItem::_change_tree(Tree *p_tree) {

                if (tree->selected_item == this) {
                        tree->selected_item = nullptr;
+                       for (Cell &cell : cells) {
+                               cell.selected = false;
+                       }
                }

                if (tree->drop_mode_over == this) {

or

diff --git a/scene/gui/tree.h b/scene/gui/tree.h
index 2dda408dd7..23040e7e50 100644
--- a/scene/gui/tree.h
+++ b/scene/gui/tree.h
@@ -176,6 +176,9 @@ private:
                                parent->first_child = next;
                        }
                }
+               for (Cell &c : cells) {
+                       c.selected = false;
+               }
        }

        bool _is_any_collapsed(bool p_only_visible);

Which also solves this, unsure which is best but as that one has some potentially wider implications I kept it simple here

[YuriSizov]

Which also solves this, unsure which is best but as that one has some potentially wider implications I kept it simple here

I prefer the local solution, so I think your PR is fine. As long as it doesn't produce any noticeable flickering.

[AThousandShips]

It happens as it clears the tree so I don't think it will, didn't notice any myself (other than the existing rendering issues with open popups)

[YuriSizov]

Thanks!

[AThousandShips]

Thank you!