-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate ARRAY_CUSTOM_RGBA8_UNORM
ref in Mesh docs
#87973
Conversation
ARRAY_CUSTOM_RGBA8_UNORM
ref in Mesh docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Looking at some of the code I think this should be CC @clayjohn Not sure if this is the code for this but this seems relevant:
|
Might need to be another constant, see comments.
Indeed, ArrayCustomFormat's docs already say it's one of the encoded as PackedByteArray formats: Lines 264 to 290 in 36e943b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Great work!
The last step before we merge this is for all the commits to be "squashed" into one commit. We like to have only one commit per PR to keep our git history clean. We have a really helpful tutorial on squashing your commits together in the docs https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html#the-interactive-rebase
The final result should be just one commit in the PR with a clear commit message
Please edit your commit message to remove unnecessary messages from commits, should just say:
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Cherry-picked for 4.2.2. |
This PR closes godotengine/godot-docs#8901
Removes duplicate reference of ARRAY_CUSTOM_RGBA8_UNORM