Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Fix processing exclusions during export #88238

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

shana
Copy link
Contributor

@shana shana commented Feb 12, 2024

When I added the filtering logic to allow excluding files or directories from the export logic, I made a mistake in the logic around deciding whether to recurse into a directory or not - it was only called if the directory itself was ignored. The intended logic should be:

  • filterDir - Process this directory?
    • if false: stop processing this directory tree
    • if true:
      • call addEntry to allow doing something with the directory entry itself
      • recurseDir - Process the contents of this directory?
        • if false: stop processing this directory tree
        • if true: recursively process this directory

This PR fixes that.

/cc @raulsntos @RedworkDE

Contrbuted by W4Games ❤️

@shana shana requested a review from a team as a code owner February 12, 2024 10:49
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@akien-mga akien-mga merged commit 7d89f55 into godotengine:master Feb 12, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants