-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid unqualified-id "near" and "far" in Node3DEditor/Viewport #88270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rename seems like it should have a small blast radius aside from git clutter.
e333df5
to
01a21a4
Compare
There are a few more cases of "far"/"near" in the godot/tests/scene/test_camera_3d.h Lines 68 to 78 in 9050ee1
|
01a21a4
to
0fbc068
Compare
0fbc068
to
cd26759
Compare
Now I believe all of them have been exterminated.. |
Some of those changes were likely not needed as there was:
(added in fe4850c) But I would then suggest to keep those changes and remove the |
cd26759
to
67e3870
Compare
Alright, I removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Thanks! |
Follow up #87164.
Current master build is failed by unqualified-id.
Previously this problem avoid by undef, but "near" and "far" are now reserved words generally, and that PR changed the reserved words in some files.
However other files also contained reserved words that needed to be changed.
(Although I feel
Windows.h
is too arrogant to use those common noun words as reserved words...🤔)